Prevent TOXID-cURL to end in redirect loop when no url is defined in settings #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update toxid_curl_oxseodecoder.php
the ssl url was never used here...
added missing ssl support
Added ssl function for shop url
added condition to disable ssl verify check for devmode
fixed replacement of http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a little addition to the _getSnippetFromXml method in toxidcurl.php to prevent the oxid shop from getting into an neverending redirect loop when no url is for the language. Now, in this case, always nothing is returned to prevent this behaviour.