Add read/write support for KHR_animation_pointer#269
Open
emackey wants to merge 1 commit intojkuhlmann:masterfrom
Open
Add read/write support for KHR_animation_pointer#269emackey wants to merge 1 commit intojkuhlmann:masterfrom
emackey wants to merge 1 commit intojkuhlmann:masterfrom
Conversation
Contributor
Author
|
Is there anything I can do to help this along? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading a glTF, the
cgltf_animation_path_typeenum (channel.target_path) gets a new possible value ofcgltf_animation_path_type_pointer, and alongside that, the animation channel has a new stringtarget_pointerwhich holds a "JSON pointer" (a string, formatted as a path within glTF's JSON). The KHR_animation_pointer extension, when properly applied to an animation channel, will both set the new enum value and populate the newtarget_pointerstring.When writing a glTF, if the new enum value is set and
target_pointeris not null, the KHR_animation_pointer extension will be written.Available "JSON pointers" in glTF are described here: The glTF Asset Object Model.
The pointer is stored in an extension specified here: KHR_animation_pointer.
Some sample assets demonstrate this in action: AnimatedColorsCube, AnimationPointerUVs