Add file size to cgltf_file_options::release callback#278
Merged
jkuhlmann merged 2 commits intojkuhlmann:masterfrom Sep 13, 2025
zeux:file-release-size
Merged
Add file size to cgltf_file_options::release callback#278jkuhlmann merged 2 commits intojkuhlmann:masterfrom zeux:file-release-size
jkuhlmann merged 2 commits intojkuhlmann:masterfrom
zeux:file-release-size
Conversation
This is necessary for POSIX systems to be able to implement file loading via mmap/munmap since munmap takes the size (unlike Windows). Without this, the implementation would need to keep a map from file pointer to file size to be able to unmap the file. This change requires minor adjustment for people who use file callbacks but the change should be very straightforward and will be flagged during the upgrade by the compiler.
We now support a full range of 3.5...3.30 to avoid breakage for the next few years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for POSIX systems to be able to implement file loading via mmap/munmap since munmap takes the size (unlike Windows). Without this, the implementation would need to keep a map from file pointer to file size to be able to unmap the file.
This change requires minor adjustment for people who use file callbacks but the change should be very straightforward and will be flagged during the upgrade by the compiler.