Skip to content

fix: bufferView.target is required by gltf v2 spec. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
REDxEYE wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix: bufferView.target is required by gltf v2 spec. #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cgltf_write.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,16 @@ static void cgltf_write_buffer_view(cgltf_write_context* context, const cgltf_bu
cgltf_write_sizeprop(context, "byteLength", view->size, (cgltf_size)-1);
cgltf_write_sizeprop(context, "byteOffset", view->offset, 0);
cgltf_write_sizeprop(context, "byteStride", view->stride, 0);
// NOTE: We skip writing "target" because the spec says its usage can be inferred.
switch (view->type) {
case cgltf_buffer_view_type_indices:
cgltf_write_sizeprop(context, "target", 34963, 0);
break;
case cgltf_buffer_view_type_vertices:
cgltf_write_sizeprop(context, "target", 34962, 0);
break;
default:
break;
}
cgltf_write_extras(context, &view->extras);
cgltf_write_line(context, "}");
}
Expand Down