Open
Conversation
- explicitly explain why `cgltf_parse` can't load URI buffers (I was going to add the code until I realized I didn't have the full path) - jkuhlmann#77 small comment about where the `cgltf_accessor.stride` comes from as its not in the gltf spec itself
zeux
reviewed
Sep 21, 2019
Contributor
zeux
left a comment
zeux
left a comment
There was a problem hiding this comment.
The comment wrt loading buffers could also refer to cgltf_load_buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgltf_parsecan't load URI buffers (I was going to add the code until I realized I didn't have the full path)cgltf_accessor.stridecomes from as its not in the gltf spec itself