Now installs with SuiteSparse v5.1.2

[rwolst]

As long as SuiteSparse v5.1.2 is installed, then the make should now work correctly in this repo. It should fix this issue also.

[jluttine]

Great, thanks a lot! I haven't used this repo in a looong time so I'm probably a bit rusty with this, but I'll try to look into this soon. It would be great to keep this working.

[rwolst]

I also plan on getting this working for https://github.com/scikit-sparse/scikit-sparse. In fact that's where I found it, as I saw your pull request here that never got merged.

[jluttine]

Nice, thanks a lot! 👍

[rwolst]

So it looks as though Debian installs the CHOLMOD in a suitesparse directory which I assume is why you head these in you include statements. I installed from source so didn't realise this was the case.

Another point to note is that in one of your tests the only need for the cholmod_internal.h include was to use TRUE which was defined as int 1. I removed this but I wonder if the need for it in the source also easy to remove, hence the file doesn't need to be included in the repo. The issue is CHOLMOD doesn't actually install the cholmod_internal.h header.

Let me know if it works for you the way it is, if not I will change my CHOLMOD installation into a suitesparse directory and change back the include statements.