-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal dockerfile, k8s example #1188
base: master
Are you sure you want to change the base?
Conversation
There's already a nice docker setup for this, but I've been using this in kubernetes pretty nicely as a cronjob.
```console | ||
$ git clone [email protected]:jmbannon/ytdl-sub.git | ||
$ cd ytdl-sub/kubernetes | ||
$ $EDITOR kustomization.yaml subs.yaml presets.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename these to subscriptions.yaml and config.yaml, to keep consistent with the documentation
@@ -0,0 +1,13 @@ | |||
FROM python:alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets include this in the k8s folder with an explanation in the README, I'd like to keep maintain this dir as the place for GH image release
# Override this with your own image if you would like. | ||
# This is a smaller image than the default that includes all the editor stuff. | ||
- name: kaictl/ytdl-sub | ||
newName: kaictl/ytdl-sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be easier for others to point to the existing headless image in the configurations, and add in the docs on how to make it faster via custom image. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, appreciate the contribution! Once we get things squared away, we should make it more official and add k8s in the Installation
list. I've seen a few folks with similar k8s setup so makes sense to better support this method, even if it confuses me 🙂
There's already a nice docker setup for this, but I've been using this in kubernetes pretty nicely as a cronjob.
Figured I might as well share if there are other people running kubernetes that want something simple like this, instead of the other options out there with fancy GUIs and stuff.
The minimal image is there so that it can run as a cronjob, keeping it as small as possible for running on a k8s cluster. It shaves off ~33% of the compressed size, so it's just a little bit faster. It's also a lot less complicated, since all we need to do is run
ytdl-sub
and nothing else.