This repository was archived by the owner on Dec 5, 2025. It is now read-only.
Make rustls-tls an optional feature for reqwest. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustls-tls includes a dependency that has a license considered copyleft (MPL-2.0). To make this library more sound to use under the MIT license, make rustls-tls an optional feature. This removes the ability to specify client certs when the `rustls-tls` feature is disabled. However, tls is enabled with reqwests defaults by default.
Contributor
Author
|
Appreciate the prompt review on the other two changes! This PR still depends on the old rustify version which uses the MPL-2.0 dependency by default. I can make it point at the rustify git directly or can update once there is a new version on crates-io if that is preferred. |
gabi-250
reviewed
Apr 26, 2022
gabi-250
left a comment
gabi-250
left a comment
There was a problem hiding this comment.
(I realize this is an old PR, but I left a few comments just in case there's any intention to merge it)
Can we add add the option to choose between native TLS and rustls for the rustify dependency as well?
Co-authored-by: Gabi Moldovan <[email protected]>
Co-authored-by: Gabi Moldovan <[email protected]>
Co-authored-by: Gabi Moldovan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls-tls includes a dependency that has a license considered
copyleft (MPL-2.0). To make this library more sound to use under the
MIT license, make rustls-tls an optional feature. This removes the
ability to specify client certs when the
rustls-tlsfeature isdisabled. However, tls is enabled with reqwests defaults by default.