Skip to content

Conversation

@randombugfixes1234
Copy link
Contributor

Hi! The vaultrs crate currently does not correctly handle this environment variable. Expected behaviour (reference to Vault docs) is as follows:

  • VAULT_SKIP_VERIFY=true : TLS verification is skipped, i.e. verification is not performed
  • VAULT_SKIP_VERIFY=false : TLS verification is not skipped, i.e. verification is performed
  • VAULT_SKIP_VERIFY is not set : TLS verification is performed by default

The current behaviour is correct when the env var is not set, but is inverted in the case that it is. In other words, currently using VAULT_SKIP_VERIFY=true with vaultrs means that verification is performed (and vice versa). The unit tests are also backwards.

This PR corrects default_verify() to handle this properly and updates the unit tests for consistency.

@stormshield-gt
Copy link
Collaborator

Thanks for the PR, I guess it supersedes #94

@stormshield-gt stormshield-gt merged commit a676a34 into jmgilman:master Nov 24, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants