Fix test incompatibility with Python 3.7 and bump travis versions #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a trailing comma in the repr of ValueError exceptions prior to python 3.7. The removal of that is breaking tests under 3.7, so this updates the expected string to incorporate whatever the built-in repr for ValueError is.
Newer distribution required for Python 3.7 and above: https://docs.travis-ci.com/user/languages/python/#python-37-and-higher
Author
|
My apologies for the travis build failures, I'm not too familiar with it. There seem to be odd limitations around specifying the more recent python versions. I bumped the distro version to xenial in the config, but the oldest python versions are failing now. I guess it raises the question if you would like to continue supporting these older releases, specifically 2.6 and 3.3? Happy to take your direction on this or chat. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a trailing comma in the repr of
ValueErrorexceptions prior to python 3.7. The removal of that is breaking tests under 3.7, so this updates the expected string to incorporate whatever the built-in repr forValueErroris.Also bumps the python version in the travis config to the official 3.7 release, rather than dev, and disallows failures.