-
Notifications
You must be signed in to change notification settings - Fork 0
feat(core): add interactive mode and key binding hooks #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zrosenbauer
wants to merge
7
commits into
main
Choose a base branch
from
feat/interactive-story
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+992
−145
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2c76337
feat(core): add interactive mode and declarative key binding hooks
zrosenbauer 989f31a
chore(repo): add changeset for interactive mode
zrosenbauer a1880d9
refactor(core): extract parseStoryId helper and tighten log types
zrosenbauer 31ae3d0
fix(core): address PR review feedback
zrosenbauer 4179e2f
refactor(core): remove deprecated spinner option from all interfaces
zrosenbauer 24db2a0
fix(core): gate interactive mode on resolved story and derive history…
zrosenbauer f9b0f36
fix(core): use object param and effect-safe refs in useKeyBinding
zrosenbauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| '@kidd-cli/core': minor | ||
| --- | ||
|
|
||
| feat(core): add interactive mode and declarative key binding hooks | ||
|
|
||
| Adds interactive mode to the stories viewer, giving story components full terminal control with the header and sidebar hidden. Press `i` to enter interactive mode and double-press `Esc` to exit. | ||
|
|
||
| Introduces reusable key handling primitives: | ||
|
|
||
| - **keys.ts**: shared key vocabulary, pattern parser, and normalizer for Ink's `useInput` | ||
| - **useKeyBinding**: declarative keymap hook supporting single keys, modifier combos, and multi-key sequences | ||
| - **useKeyInput**: enhanced raw input hook with normalized key events |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,4 +18,4 @@ | |
| "tsx": "catalog:", | ||
| "typescript": "catalog:" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
packages/core/src/stories/viewer/hooks/use-double-escape.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * Thin wrapper hook that listens for a double-press Escape sequence | ||
| * and invokes an exit callback. Used by the stories viewer to exit | ||
| * interactive mode without intercepting single Escape presses. | ||
| * | ||
| * @module | ||
| */ | ||
|
|
||
| import { useMemo } from 'react' | ||
|
|
||
| import type { KeyBinding } from '../../../ui/use-key-binding.js' | ||
| import { useKeyBinding } from '../../../ui/use-key-binding.js' | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // Types | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** | ||
| * Options for the {@link useDoubleEscape} hook. | ||
| */ | ||
| interface DoubleEscapeOptions { | ||
| readonly onExit: () => void | ||
| readonly isActive: boolean | ||
| } | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // Exports | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** | ||
| * Listen for a double-press Escape sequence and call `onExit` when detected. | ||
| * The binding is only active when `isActive` is `true`, allowing the caller | ||
| * to enable it only in interactive mode. | ||
| * | ||
| * @param options - The hook options with exit callback and active state. | ||
| */ | ||
| export function useDoubleEscape({ onExit, isActive }: DoubleEscapeOptions): void { | ||
| const bindings = useMemo<readonly KeyBinding[]>( | ||
| () => [{ keys: 'escape escape', action: onExit }], | ||
| [onExit] | ||
| ) | ||
| useKeyBinding(bindings, { isActive }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.