Skip to content

fix(receive): block new addresses during rescan - #1367

Merged
parrth20 merged 2 commits into
develfrom
parth/rescan-addresses
Jul 29, 2026
Merged

fix(receive): block new addresses during rescan#1367
parrth20 merged 2 commits into
develfrom
parth/rescan-addresses

Conversation

@parrth20

Copy link
Copy Markdown
Member

Summary

  • Prevent new address requests while a wallet rescan is active.
  • Disable the reveal and refresh address buttons during rescanning.
  • Add regression coverage for the rescan state.

Closes #1361

@parrth20 parrth20 self-assigned this Jul 28, 2026
@parrth20 parrth20 added bug Something isn't working security Issues related to security; could lead to loss of funds SoB Issues, PRs, tasks, and discussions related to Summer of Bitcoin. beta labels Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 89.53% (🎯 85%) 4554 / 5086
🟢 Statements 89.12% (🎯 85%) 5001 / 5611
🟢 Functions 87.25% (🎯 85%) 1623 / 1860
🟢 Branches 81.33% (🎯 80%) 3019 / 3712
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/receive/ReceivePage.tsx 87.5% 92.1% 78.57% 89.18% 88, 107, 112, 231-232
Generated in workflow #3495 for commit 8583cca by the Vitest Coverage Report Action

Comment thread src/components/receive/ReceivePage.test.tsx
}

const fetchNewAddress = async () => {
if (rescanInfo.rescanning) return

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed or externalized into a variable (e.g. !operationEnabled) so there is a single place to change, should there be further restrictions?

e.g. imho this might also be true if the maker is running, since collaborative tx outputs come from purpose "receive" (m/84'/0'/{jarIndex}'/0/x) instead of the "change" (m/84'/0'/{jarIndex}'/1/x).

Is that taken care of in joinmarket-ng (maker does not use address already shown to the user and vice versa) @m0wer ?

@theborakompanioni theborakompanioni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only NITs -> ACK.

@theborakompanioni theborakompanioni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK.

@parrth20
parrth20 merged commit ff0a9f2 into devel Jul 29, 2026
7 checks passed
@parrth20
parrth20 deleted the parth/rescan-addresses branch July 29, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta bug Something isn't working security Issues related to security; could lead to loss of funds SoB Issues, PRs, tasks, and discussions related to Summer of Bitcoin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: prevent loading new addresses while rescanning

2 participants