fix(receive): block new addresses during rescan - #1367
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
| } | ||
|
|
||
| const fetchNewAddress = async () => { | ||
| if (rescanInfo.rescanning) return |
Collaborator
There was a problem hiding this comment.
Can this be removed or externalized into a variable (e.g. !operationEnabled) so there is a single place to change, should there be further restrictions?
e.g. imho this might also be true if the maker is running, since collaborative tx outputs come from purpose "receive" (m/84'/0'/{jarIndex}'/0/x) instead of the "change" (m/84'/0'/{jarIndex}'/1/x).
Is that taken care of in joinmarket-ng (maker does not use address already shown to the user and vice versa) @m0wer ?
theborakompanioni
previously approved these changes
Jul 28, 2026
theborakompanioni
left a comment
Collaborator
There was a problem hiding this comment.
Only NITs -> ACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1361