Feature/add choice parameter and raise an exception if fetched value is not within#555
Merged
joke2k merged 4 commits intojoke2k:developfrom Feb 17, 2026
Conversation
…ces. Raise improperlyConfigured if the value is not within choices.
Contributor
Author
|
@joke2k hello ! Have you some time to review the proposed PR ? Would be much appreciate. |
…-exception-if-fetched-value-is-not-within
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Thank you @Swannbm for the contribution and collaboration on this feature. Really appreciated by the maintainers and community. 🙌 |
ulgens
pushed a commit
to ulgens/django-environ
that referenced
this pull request
Feb 22, 2026
…is not within (joke2k#555) * set new parameter in str to coerce value into a specific list of choices. Raise improperlyConfigured if the value is not within choices. * Fix indentation after rebase in Env.str Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Document Env.str choices option Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Daniele Faraglia <joke2k@users.noreply.github.com> Co-authored-by: joke2k <daniele.faraglia@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #193 (specifying allowed options)
Use case 1:
We don't want to hide warnings because a log-reading probe catches them and triggers an alert.
Use case 2:
Define a set of execution environments with dedicated settings, and ensure the app is running in one of them.
Solution proposed:
str.choicesparameter toEnv.str()to allow the user to define allowed options.I have limited the scope of work, but I can extend the mechanism to some other fetching methods if you see use cases...
Let me know if some corrections are needed.