Add Docker Support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
reviewed
Sep 18, 2024
Fan2Shrek
force-pushed
the
add-docker
branch
from
c8a2935 to
09efce0
Compare
|
Done, but not sure if the test is relevant though. |
pyrech
approved these changes
Oct 2, 2024
|
Sorry for the delay, I forgot to-rereview your PR. I agree It's a bit hard to make really useful tests on this library 😅 We may try to improve them in the future. Let's merge your PR. Thanks for your work ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Docker in WSL does not seem to be correctly identified.
I tried to add Docker support, but I'm not sure if it's the best solution :)