Skip to content

Commit

Permalink
Optimize JS performance by using different UID generator and remove b…
Browse files Browse the repository at this point in the history
…ind statements
  • Loading branch information
wkh237 committed May 15, 2017
1 parent 1ebbb89 commit 680331d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 14 deletions.
20 changes: 10 additions & 10 deletions polyfill/XMLHttpRequest.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
})
.fetch(_method, _url, _headers, body)
this._task
.stateChange(this._headerReceived.bind(this))
.uploadProgress(this._uploadProgressEvent.bind(this))
.progress(this._progressEvent.bind(this))
.catch(this._onError.bind(this))
.then(this._onDone.bind(this))
.stateChange(this._headerReceived)
.uploadProgress(this._uploadProgressEvent)
.progress(this._progressEvent)
.catch(this._onError)
.then(this._onDone)

})
}
Expand Down Expand Up @@ -274,7 +274,7 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
return result.substr(0, result.length-2)
}

_headerReceived(e) {
_headerReceived = (e) => {
log.debug('header received ', this._task.taskId, e)
this.responseURL = this._url
if(e.state === "2") {
Expand All @@ -285,7 +285,7 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
}
}

_uploadProgressEvent(send:number, total:number) {
_uploadProgressEvent = (send:number, total:number) => {
if(!this._uploadStarted) {
this.upload.dispatchEvent('loadstart')
this._uploadStarted = true
Expand All @@ -295,7 +295,7 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
this.upload.dispatchEvent('progress', new ProgressEvent(true, send, total))
}

_progressEvent(send:number, total:number, chunk:string) {
_progressEvent = (send:number, total:number, chunk:string) => {
log.verbose(this.readyState)
if(this._readyState === XMLHttpRequest.HEADERS_RECEIVED)
this._dispatchReadStateChange(XMLHttpRequest.LOADING)
Expand All @@ -310,7 +310,7 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
this.dispatchEvent('progress', e)
}

_onError(err) {
_onError = (err) => {
let statusCode = Math.floor(this.status)
if(statusCode >= 100 && statusCode !== 408) {
return
Expand All @@ -331,7 +331,7 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget{
this.clearEventListeners()
}

_onDone(resp) {
_onDone = (resp) => {
log.debug('XMLHttpRequest done', this._url, resp, this)
this._statusText = this._status
let responseDataReady = () => {
Expand Down
6 changes: 2 additions & 4 deletions utils/uuid.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
export default function getUUID() {
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(c) {
let r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8);
return v.toString(16);
});
return Math.random().toString(36).substring(2, 15) +
Math.random().toString(36).substring(2, 15);
}

0 comments on commit 680331d

Please sign in to comment.