Add DownloadableFileBlock interface for Pdf, File, and Image blocks#184
Merged
jomei merged 1 commit intojomei:mainfrom Dec 20, 2024
Merged
Conversation
This change: - Adds new interface to unify common functionality - Implements interface for PdfBlock, FileBlock, and ImageBlock - Adds comprehensive test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
This PR adds a new
DownloadableFileBlockinterface to unify common functionality between Pdf, FileBlock, and Image blocks.Changes:
DownloadableFileBlockinterfaceThe interface provides:
GetURL() string- returns the URL of the fileGetExpiryTime() *time.Time- returns the expiry time of the fileThis reduces switch-case statements in client code by providing a common interface for these similar block types.