Skip to content

Add date format option with tests#188

Open
aydinomer00 wants to merge 1 commit intojomei:mainfrom
aydinomer00:feature/date-only-format
Open

Add date format option with tests#188
aydinomer00 wants to merge 1 commit intojomei:mainfrom
aydinomer00:feature/date-only-format

Conversation

@aydinomer00
Copy link
Contributor

@aydinomer00 aydinomer00 commented Dec 30, 2024

  • Add Date struct with DateOnly flag
  • Implement custom date formatting for Notion API
  • Add comprehensive test coverage
  • Fix timezone formatting in FormatForNotion
  • Handle null values in UnmarshalJSON
  • Closes Option for choosing the Date format #177

@aydinomer00
Add date format option with tests
78b0f25 
- Add Date struct with DateOnly flag
- Implement custom date formatting for Notion API
- Add comprehensive test coverage
- Fix timezone formatting in FormatForNotion
- Handle null values in UnmarshalJSON
- Closes jomei#177
@wolveix
Copy link
Contributor

wolveix commented Oct 1, 2025

@aydinomer00 this would be great to have :D Before @jomei has time to review it (hopefully soon?), here were my thoughts:

  • I don't think it makes sense to move these into a new pkg/models directory when the rest of the repo doesn't already follow that structure
  • Following the conventions of the rest of the library, date.go and date_object.go should be under one file

giovanism added a commit to giovanism/notionapi that referenced this pull request Dec 13, 2025
@giovanism
feat: Add date format option with tests
0f93213 
Adaptation from jomei#188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option for choosing the Date format

2 participants

@aydinomer00 @wolveix