Skip to content

chore: support startTime and duration value in milliseconds #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yujune wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: support startTime and duration value in milliseconds #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/kotlin/com/example/video_compress/VideoCompressPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class VideoCompressPlugin : MethodCallHandler, FlutterPlugin {

val dataSource = if (startTime != null || duration != null){
val source = UriDataSource(context, Uri.parse(path))
TrimDataSource(source, (1000 * 1000 * (startTime ?: 0)).toLong(), (1000 * 1000 * (duration ?: 0)).toLong())
TrimDataSource(source, (1000 * (startTime ?: 0)).toLong(), (1000 * (duration ?: 0)).toLong())
}else{
UriDataSource(context, Uri.parse(path))
}
Expand Down
4 changes: 2 additions & 2 deletions ios/Classes/SwiftVideoCompressPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ public class SwiftVideoCompressPlugin: NSObject, FlutterPlugin {
Utility.getPathUrl("\(Utility.basePath())/\(Utility.getFileName(path))\(uuid.uuidString).\(sourceVideoType)")

let timescale = sourceVideoAsset.duration.timescale
let minStartTime = Double(startTime ?? 0)
let minStartTime = Double(startTime ?? 0) / 1000.0

let videoDuration = sourceVideoAsset.duration.seconds
let minDuration = Double(duration ?? videoDuration)
let minDuration = Double(duration != nil ? ((duration ?? 0) / 1000.0) : videoDuration)
let maxDurationTime = minStartTime + minDuration < videoDuration ? minDuration : videoDuration

let cmStartTime = CMTimeMakeWithSeconds(minStartTime, preferredTimescale: timescale)
Expand Down