Skip to content

chore: remove isCompressing checking for concurrent compress. #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yujune wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: remove isCompressing checking for concurrent compress. #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7fdad5
chore: remove isCompressing checking to allow simultaneous compress.
yujunetee Apr 23, 2025
aa2dd5d
chore: remove isCompressing flag.
yujunetee Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions lib/src/progress_callback/compress_mixin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';

import 'subscription.dart';

class CompressMixin {
Expand All @@ -13,15 +14,6 @@ class CompressMixin {

MethodChannel get channel => _channel;

bool _isCompressing = false;

bool get isCompressing => _isCompressing;

@protected
void setProcessingStatus(bool status) {
_isCompressing = status;
}

Future<void> _progressCallback(MethodCall call) async {
switch (call.method) {
case 'updateProgress':
Expand Down
12 changes: 0 additions & 12 deletions lib/src/video_compress/video_compressor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'dart:typed_data';

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
Expand Down Expand Up @@ -129,19 +128,11 @@ extension Compress on IVideoCompress {
bool? includeAudio,
int frameRate = 30,
}) async {
if (isCompressing) {
throw StateError('''VideoCompress Error:
Method: compressVideo
Already have a compression process, you need to wait for the process to finish or stop it''');
}

if (compressProgress$.notSubscribed) {
debugPrint('''VideoCompress: You can try to subscribe to the
compressProgress\$ stream to know the compressing state.''');
}

// ignore: invalid_use_of_protected_member
setProcessingStatus(true);
final jsonStr = await _invoke<String>('compressVideo', {
'path': path,
'quality': quality.index,
Expand All @@ -152,9 +143,6 @@ extension Compress on IVideoCompress {
'frameRate': frameRate,
});

// ignore: invalid_use_of_protected_member
setProcessingStatus(false);

if (jsonStr != null) {
final jsonMap = json.decode(jsonStr);
return MediaInfo.fromJson(jsonMap);
Expand Down