Change Windows SDK version to 10.0.22621 for XP builds - #5795
Merged
Conversation
Contributor
|
You're referring to "Microsoft.VisualStudio.Component.Windows10SDK.22621", but in the Github readme files I see only Windows11SDK.22621. From which list are you choosing the version? |
Contributor
Author
|
@Torinde Please carefully learn about SDK versions before asking. |
Contributor
Author
|
It mentions that checks for PR somehow failed, but worked on my repository so it should be ready. |
Contributor
FYI, in case that affects the SDK selection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes recent build failures of XP VS builds, due to missing Windows SDK (10.0.22000) which Microsoft have dropped support.
SDK 10.0.22621 is used instead.
Tried on Windows XP 32bit SDL1 & SDL2.
What issue(s) does this PR address?
Fixes #5794