Cheater - #6012
Conversation
|
There are some interesting errors from the CI builds. Can you address them? Go to each CI build and use the search function to highlight every line that contains the text "error:" (without the quotes). The Linux ones appear to be a simple one-line change to include the required header for a C standard library function. |
|
I have reviewed all the compilation error messages, and the main errors stem from the compiler not recognizing the CHEAT object. My program uses conditional compilation, which requires defining the variable C_CHEAT for proper compilation. I am unsure how to define this variable on other platforms, leading to compilation failures. Could you assist me in completing this task? Alternatively, should I directly remove all conditional compilation statements to allow the compilation to proceed normally? THANK YOU VERY MUCH.
…________________________________
寄件者: Jonathan Campbell ***@***.***>
寄件日期: 2025年12月24日 下午 06:23
收件者: joncampbell123/dosbox-x ***@***.***>
副本: knifour ***@***.***>; Author ***@***.***>
主旨: Re: [joncampbell123/dosbox-x] Cheater (PR #6012)
[https://avatars.githubusercontent.com/u/6245486?s=20&v=4]joncampbell123 left a comment (joncampbell123/dosbox-x#6012)<#6012 (comment)>
There are some interesting errors from the CI builds. Can you address them?
Go to each CI build and use the search function to highlight every line that contains the text "error:" (without the quotes).
The Linux ones appear to be a simple one-line change to include the required header for a C standard library function.
—
Reply to this email directly, view it on GitHub<#6012 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADZOFMDH2LTKYLEYMAEAQX34DLK2PAVCNFSM6AAAAACP4VVDEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJQGM2DMNBYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Or should I change all the `C_CHEAT` conditional compilation to `C_DEBUG`? Since my program is integrated within the Debugger, using this compilation condition might better suit the requirements?
…________________________________
寄件者: Jonathan Campbell ***@***.***>
寄件日期: 2025年12月24日 下午 06:23
收件者: joncampbell123/dosbox-x ***@***.***>
副本: knifour ***@***.***>; Author ***@***.***>
主旨: Re: [joncampbell123/dosbox-x] Cheater (PR #6012)
[https://avatars.githubusercontent.com/u/6245486?s=20&v=4]joncampbell123 left a comment (joncampbell123/dosbox-x#6012)<#6012 (comment)>
There are some interesting errors from the CI builds. Can you address them?
Go to each CI build and use the search function to highlight every line that contains the text "error:" (without the quotes).
The Linux ones appear to be a simple one-line change to include the required header for a C standard library function.
—
Reply to this email directly, view it on GitHub<#6012 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADZOFMDH2LTKYLEYMAEAQX34DLK2PAVCNFSM6AAAAACP4VVDEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJQGM2DMNBYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
The erroneous code is because I forgot to put it inside the C_CHEAT conditional compilation block. If I place it under C_CHEAT, it definitely won’t cause errors anymore, but it will also result in other platforms not having the CHEATER function even if the compilation succeeds.
Please give me suggestions, and I will modify my code according to your advice. I will handle and fix the issue regarding the missing `#include <cstring>` on the Linux platform.
Many thanks.
from Knifour
…________________________________
寄件者: Jonathan Campbell ***@***.***>
寄件日期: 2025年12月24日 下午 06:23
收件者: joncampbell123/dosbox-x ***@***.***>
副本: knifour ***@***.***>; Author ***@***.***>
主旨: Re: [joncampbell123/dosbox-x] Cheater (PR #6012)
[https://avatars.githubusercontent.com/u/6245486?s=20&v=4]joncampbell123 left a comment (joncampbell123/dosbox-x#6012)<#6012 (comment)>
There are some interesting errors from the CI builds. Can you address them?
Go to each CI build and use the search function to highlight every line that contains the text "error:" (without the quotes).
The Linux ones appear to be a simple one-line change to include the required header for a C standard library function.
—
Reply to this email directly, view it on GitHub<#6012 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADZOFMDH2LTKYLEYMAEAQX34DLK2PAVCNFSM6AAAAACP4VVDEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJQGM2DMNBYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
The first and simplest one is to add #include <string.h> to the top of the source file where memset() is used. That would fix Linux builds. |
|
You should be able to make these corrections and push them to the branch you've submitted to merge, and it should reflect the changes here. |
|
@knifour I've described how to fix this. I can't make the changes for you. They are fairly simple changes to make. If you push to your branch set up to merge here, the CI system here on GitHub should run the build with your changes and show that they no longer cause compile failures This looks like an interesting cheat system that may be useful for others. |
Changes: 1. Remove platform-specific C_CHEAT compilation flags 2. Integrate functionality into existing C_DEBUG framework 3. Restore build-mingw-sdl2 and vs/config.h to upstream original versions Benefits: - Ensure Game Cheater works on all platforms supporting debug mode - Reduce platform-specific maintenance burden - Clearer feature logic (as a debug tool extension)
|
Please look at the error messages. Many of them are one-line changes. I'm not going to merge something that breaks the code. If this process takes too long, the code will drift to the point your patch will no longer apply. |


Add a summary of the change(s) brought by this PR here.
Add Game Cheater utility integrated under debugger mode
This PR integrates a Game Cheater utility as an extension of the debugger. Once the debugger is activated, users can launch the cheater by entering the command:
CHEAT ProjectNameFull Tutor
https://knifour.gitbook.io/dosbox-x-game-cheater/
What issue(s) does this PR address?
If there are any related issues, reference them here. Ex. #1234, Fixes #1234, Closes #1234, etc.
Does this PR introduce new feature(s)?
If yes, describe the feature(s) introduced.
Does this PR introduce any breaking change(s)?
If yes, describe the breaking change(s) in detail.
Additional information
Add any additional information here.