Skip to content

Remove CMS DB aware trait #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove CMS DB aware trait #441

wants to merge 1 commit into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 17, 2025

User description

For joomla/joomla-cms#45340


PR Type

documentation


Description

  • Documented the removal of CMS DatabaseAwareTrait class.

  • Suggested using Joomla\Database\DatabaseAwareTrait as a replacement.


Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Documented removal of CMS DatabaseAwareTrait class             

migrations/54-60/removed-backward-incompatibility.md

  • Added a note about the removal of CMS DatabaseAwareTrait.
  • Provided a replacement suggestion with
    Joomla\Database\DatabaseAwareTrait.
  • Linked the relevant PR for reference.
  • +6/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Specify removed trait name

    Clarify that the removed trait is Joomla\CMS\MVC\Model\DatabaseAwareTrait to
    avoid confusion, as the current description only mentions the replacement trait
    but not the fully qualified name of the removed trait.

    migrations/54-60/removed-backward-incompatibility.md [201]

    -- Description: The trait `Joomla\Database\DatabaseAwareTrait` should be used instead as they both contain the same functionality.
    +- Description: The trait `Joomla\CMS\MVC\Model\DatabaseAwareTrait` has been removed. The trait `Joomla\Database\DatabaseAwareTrait` should be used instead as they both contain the same functionality.
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies that the description is missing the fully qualified name of the removed trait, which is crucial information for developers who need to migrate their code. Adding the complete class name Joomla\CMS\MVC\Model\DatabaseAwareTrait significantly improves clarity and prevents confusion.

    High
    • More

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant