Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided Tours] Global Configuration delay field fix #44091

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

obuisard
Copy link
Contributor

Summary of Changes

The 'delay' parameter is not filtered, allowing any character in the field.

Testing Instructions

Go to the Global Configuration of the Guided Tours.

Actual result BEFORE applying this Pull Request

Enter a value in the field 'Auto Start Time Delay (in minutes)'. Try entering letters.
You can set the field to any character other than numbers.

Expected result AFTER applying this Pull Request

You can no longer enter anything else but numbers.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 78b9713


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

@Quy
Copy link
Contributor

Quy commented Sep 16, 2024

I have tested this item ✅ successfully on 00ac35d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

1 similar comment
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 00ac35d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

@tecpromotion
Copy link
Contributor

RTC

@Quy Quy added the RTC This Pull Request is Ready To Commit label Sep 17, 2024
@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Sep 17, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 17, 2024
@Hackwar Hackwar enabled auto-merge (squash) September 23, 2024 07:49
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 23, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 23, 2024

Thank you for your contribution @obuisard!

@Hackwar Hackwar merged commit e4fb51a into joomla:5.2-dev Sep 23, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants