-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [Guided Tours] Global Configuration delay field fix #44091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 78b9713 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091. |
Quy
reviewed
Sep 16, 2024
Co-authored-by: Quy <[email protected]>
I have tested this item ✅ successfully on 00ac35d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091. |
1 similar comment
I have tested this item ✅ successfully on 00ac35d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091. |
RTC |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44091. |
Thank you for your contribution @obuisard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The 'delay' parameter is not filtered, allowing any character in the field.
Testing Instructions
Go to the Global Configuration of the Guided Tours.
Actual result BEFORE applying this Pull Request
Enter a value in the field 'Auto Start Time Delay (in minutes)'. Try entering letters.
You can set the field to any character other than numbers.
Expected result AFTER applying this Pull Request
You can no longer enter anything else but numbers.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed