Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pre-commit #391

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 0 additions & 90 deletions .pre-commit-config.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
[![Lmo - SPEC 0][IMG-SPEC0]][SPEC0]
[![Lmo - BSD License][IMG-BSD]][BSD]
[![Lmo - CI][IMG-CI]][CI]
[![Lmo - pre-commit][IMG-PC]][PC]
[![Lmo - ruff][IMG-RUFF]][RUFF]
[![Lmo - bassedpyright][IMG-BPR]][BPR]
![PyPI - Types](https://img.shields.io/pypi/types/Lmo)
Expand Down Expand Up @@ -133,7 +132,6 @@ See [SPEC 0][SPEC0] for more information.
[IMG-SPEC0]: https://img.shields.io/badge/SPEC-0-green?labelColor=%23004811&color=%235CA038
[IMG-BSD]: https://img.shields.io/github/license/jorenham/Lmo
[IMG-CI]: https://img.shields.io/github/actions/workflow/status/jorenham/Lmo/ci.yml?branch=master
[IMG-PC]: https://img.shields.io/badge/pre--commit-enabled-orange?logo=pre-commit
[IMG-RUFF]: https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json
[IMG-BPR]: https://img.shields.io/badge/basedpyright-checked-42b983

Expand All @@ -143,7 +141,6 @@ See [SPEC 0][SPEC0] for more information.
[BSD]: https://github.com/jorenham/Lmo/blob/master/LICENSE
[CI]: https://github.com/jorenham/Lmo/actions/workflows/ci.yml?query=branch%3Amaster

[PC]: https://github.com/pre-commit/pre-commit
[RUFF]: https://github.com/astral-sh/ruff
[BPR]: https://github.com/detachhead/basedpyright/
[PY]: https://github.com/python/cpython
Expand Down
15 changes: 0 additions & 15 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ You can install the dev dependencies using
uv sync
```

### pre-commit

Lmo uses [pre-commit](https://pre-commit.com/) to ensure that the code is
formatted and typed correctly when committing the changes.

```bash
uv run pre-commit install
```

It can also be manually run:

```bash
uv run pre-commit --all-files
```

### Testing

Lmo uses [pytest](https://docs.pytest.org/en/stable/) and
Expand Down
12 changes: 2 additions & 10 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ dev = [
"blacken-docs>=1.19.1",
"codespell>=2.3.0",
"hypothesis[numpy]>=6.123.17",
"pre-commit>=4.0.1",
"basedpyright>=1.24.0",
"pytest>=8.3.4",
"pytest-doctestplus>=1.3.0",
Expand Down Expand Up @@ -153,7 +152,7 @@ reportUnusedVariable = false # dupe of F841

[tool.repo-review]
# TODO: basedmypy
ignore = ["PC140", "MY", "RTD"]
ignore = ["PY006", "PC140", "MY", "RTD"]

[tool.ruff]
force-exclude = true
Expand Down Expand Up @@ -267,7 +266,7 @@ allow-magic-value-types = ["int" ,"str"]

[tool.tox]
isolated_build = true
env_list = ["repo-review", "pre-commit", "3.11", "3.12", "3.13"]
env_list = ["repo-review", "3.11", "3.12", "3.13"]

[tool.tox.env_run_base]
description = "test with {base_python}"
Expand All @@ -276,13 +275,6 @@ allowlist_externals = ["uv"]
commands_pre = [["uv", "sync", "--frozen", "--dev"]]
commands = [["uv", "run", "pytest"]]

[tool.tox.env.pre-commit]
description = "pre-commit"
skip_install = true
allowlist_externals = ["uv"]
commands_pre = [["uv", "sync", "--frozen", "--dev"]]
commands = [["uv", "run", "pre-commit", "run", "--all-files"]]

[tool.tox.env.repo-review]
description = "repo-review"
skip_install = true
Expand Down
47 changes: 2 additions & 45 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.