Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules/
.idea/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<random-thought>
Random comment having nothing to do with this class nor even javascript: you can define a global gitignore file that applies to all repositories, which is a good place for stuff like this. I do it that way so I can omit files that my editor generates without (a) having to change every gitignore in every repo I ever touch; and (b) to prevent committing irrelevant code to repos.
</random-thought>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you could define a global .gitignore across repositories as I mostly just write them per-project. Are you simply just keeping the configurations in a common repository or are you doing any special Github linking between projects?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's more "set it and forget it". Check out the link from my first comment. You just keep a file on your computer someplace that looks like a gitignore file and you put its location in your configuration for git (can be done from cli too).

35 changes: 28 additions & 7 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,35 @@ export function doubleXTimes ( x, num ) {
return result;
}

export function doubleEach ( arr ) {
let result = arr.map( double );
export const doubleEach = x => x.map(double);

// const result = arr.map( x => double( x ) );
// const result = arr.map( function ( x ) {
// return double( x );
// });
export function Animal() {
this.clorophyll = false;
}
Animal.SOUND = 'generic sound';
Animal.prototype.speak = function () {return this.constructor.SOUND};

return result;
export function Reptile() {
this.scales = true;
}

Reptile.SOUND = 'Roar';
Reptile.prototype = new Animal();
Reptile.prototype.constructor = Reptile;

export function Primate() {
this.thumbs = true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to call the Animal constructor within this constructor, and "bind" it to this instance.

}
Primate.SOUND = 'Ooh ooh eee!';
Primate.prototype = new Animal();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're looking for Object.create here. Much cleaner. Otherwise, chlorophyll is defined on the prototype instead of the instance, which isn't in line with what you did with animal. Also see comment above.

Primate.prototype.constructor = Primate;

export function Human() {
this.sentience = true;
}
Human.SOUND = 'hello';
Human.prototype = new Primate();
Human.prototype.constructor = Human;



59 changes: 58 additions & 1 deletion src/spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import test from 'tape';
import { double, doubleXTimes, doubleEach } from './index';
import { double, doubleXTimes, doubleEach, Animal, Reptile, Primate, Human} from './index';

test( 'double fn', function ( test ) {
const actual = double( 5 );
Expand Down Expand Up @@ -28,3 +28,60 @@ test( 'doubleEach', function ( test ) {
test.end();
});

test('Test to see if a new "Animal" instance can be created', function (test) {
const animal = new Animal();
test.ok( animal instanceof Animal, 'should create an instance of Animal');
test.end();
});

test('Test to see if the Animal type has a "speak" method', function (test) {

const animal = new Animal();
const expected = 'generic sound';
const actual = animal.speak();

test.equal( actual, expected, 'should make a generic sound when it speaks' );
test.end();
});

test('Test to see if "Primates" and "Reptiles" can be made from "Animals"', function (test) {

let actual, expected;

const reptile = new Reptile();

test.ok( reptile instanceof Reptile, 'should be an instance of Reptile' );
test.ok( reptile instanceof Animal, 'should be an instance of Animal' );

expected = Reptile.SOUND;
actual = reptile.speak();
test.equal( actual, expected, 'should make a reptile sound when it speaks' );

const primate = new Primate();

test.ok( primate instanceof Primate, 'should be an instance of Primate' );
test.ok( primate instanceof Animal, 'should be an instance of Animal' );

expected = Primate.SOUND;
actual = primate.speak();
test.equal( actual, expected, 'should make a primate sound when it speaks' );

test.end();
});

test('Test to see if a human can be made and it can speak', function (test) {

let actual, expected;

const human = new Human();

test.ok( human instanceof Human, 'should be an instance of Human' );
test.ok( human instanceof Primate, 'should be an instance of Primate' );
test.ok( human instanceof Animal, 'should be an instance of Animal' );

const message = 'hello';
expected = message;
actual = human.speak( message );
test.equal( actual, expected, 'should speak what it is asked to speak' );
test.end();
});