feat(base): add redirect_slashes option to mount_to method #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowilf
requested changes
Jan 9, 2025
Adds a `redirect_slashes` parameter to the `mount_to` method of the `BaseAdmin` class and its subclasses. This allows users to control whether or not slashes are redirected when mounting the admin interface. Signed-off-by: Noam Stolero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 76 +1
Lines 5817 5906 +89
=========================================
+ Hits 5817 5906 +89 ☔ View full report in Codecov by Sentry. |
jowilf
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional redirect_slashes parameter to
BaseAdmin.mount_to()and propagate it to SQLAlchemy Admin class. This allows users to control whether trailing slashes in URLs should be redirected, providing more flexibility in URL handling.I'm working on a a litestar plugin to this awesome lib.
Inspired by https://github.com/peterschutt/sqladmin-litestar-plugin
Because of Starlette issue: encode/starlette#869
We have to turn of redirect_slashes. In all of the nested Starlette apps.
Because admin_app is created deep in the Base class, it's impossible to do it without hacking the lib.
This PR makes it convenient and is backward compatible.
If you have suggestions how to do it better, let me know!