use new meta method to fetch token#91
Open
MusikAnimal wants to merge 1 commit intojpatokal:masterfrom
Open
Conversation
Owner
|
Thanks, but since people often use this to connect to older versions I can't accept a breaking change. Can you rewrite this either to try/catch both methods, or poke at eg. https://www.mediawiki.org/wiki/API:Siteinfo and check the version there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per API:Tokens, with MediaWiki v1.24 or later we should be fetching a token via
action=query&meta=tokens, disregarding the page we are actioning on. This of course means we are dropping support for earlier MediaWiki versions. Maybe there's a way to check which version they are using?