-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BG localization grammatical errors #1911
base: main
Are you sure you want to change the base?
Fix BG localization grammatical errors #1911
Conversation
|
Thanks for your contribution! Before merging this PR we'll need some review of the localization file, see https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations Please fix the CGL issue and change commit message to something like "Datepicker: Fix Bulgarian localization grammatical errors" |
dayNamesShort: [ "Нед","Пон","Вто","Сря","Чет","Пет","Съб" ], | ||
dayNamesMin: [ "Не","По","Вт","Ср","Че","Пе","Съ" ], | ||
currentText: "Днес", | ||
monthNames: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is actually the nicer CGL style, but I would like to keep the code style as it was before. Reasons are: we want to keep consistency and it makes the review harder. Please change to one line per localization key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit message to: "Datepicker: Fix grammatical errors in Bulgarian localization"
Datepicker: Fix multiple grammar mistakes in BG localization file
There is a grammatical rule in Bulgarian language when word is shortened - the last letter must be always consonant.
However, for months and days there are official abbreviations, as follows:
Days -> "Нед.", "Пон.", "Втор.", "Ср.", "Четв.", "Пет.", "Съб."
Months -> "Ян.", "Февр.", "Мар", "Апр.", "Май", "Юни", "Юли", "Авг.", "Септ.", "Окт.", "Ноем.", "Дек."
Also year should have suffix "г." for example "2020 г."
"closeText", "prevText", "nextText", currentText must start with capital letter.
For reference