Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create datepicker-jp.js #1937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create datepicker-jp.js #1937

wants to merge 1 commit into from

Conversation

khanamtechasia
Copy link

Japanese language for jquery datepicker.

@khanamtechasia
Create datepicker-jp.js
fe2d489 
Japanese language for jquery datepicker.
@jsf-clabot
Copy link

jsf-clabot commented Sep 25, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@fnagel
Copy link
Member

fnagel commented Oct 6, 2020

Thanks for your contribution!

We need some more reviews of the localization before merging this. Please see here for more info: https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations

@fnagel fnagel self-assigned this Nov 3, 2020
Base automatically changed from master to main February 19, 2021 19:58
markvantilburg
markvantilburg reviewed Jun 5, 2024
View reviewed changes
ui/i18n/datepicker-jp.js
"七月", "八月", "九月", "十月", "十一月", "十二月" ],
monthNamesShort: [ "1月", "2月", "3月", "4月", "5月", "6月",
"7月", "8月", "9月", "10月", "11月", "12月" ],
dayNames: [ "日曜日", "月曜", "火曜日", "水曜日", "木曜日", "金曜日", "土曜日", "日曜日" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot read japanese. There are 8 dayNames here (according to google translate Sunday is there twice).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. You're right, that looks wrong. Even without speaking Japanese.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markvantilburg markvantilburg markvantilburg left review comments

@fnagel fnagel fnagel left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@fnagel fnagel

Labels
Feature Localization
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanamtechasia @jsf-clabot @fnagel @markvantilburg