Add users by email or whatever #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loutUi.find_users_by(field) config options. Currently ActiveRecord-only but could be expanding to support other ORMs easily.
…for everything to be inline.
|
Just my 2 cents: @Empact thanks for your diff anyway! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to set a field other than id for use in the third column.
The user calls:
RolloutUi.find_users_by(:email), and the email field is used to Users. The user can also set the target user class for this operation viaRolloutUi.user_class =.The changes would need to be carried over to the sinatra side as well before they're released, and there's room to debate over whether this is too general or not general enough a solution, but this is good enough for my purposes, so I submit it for your consideration.
There are also some minor incidental fixes included in this pull request, most notably: 5f1aa29