Updates for nixpkg #495
Draft
Updates for nixpkg #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nix sets them to an absolute path with clashes with the usual assumtion that GNUInstallPaths returns them as relative names (e.g lib, bin, ...)
This is required to build controllers into a separate install prefix in nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#494 made it possible to build mc_rtc itself with nixpkg. This PR is a follow-up with subsequent fixes for downstream projects (mc_rtc-magnum, controllers, plugins, etc). I'll leave it open until enough use-cases have been integrated and tested in mc-rtc/nixpkgs#1
sva::PTransformdwith niceties (automatic display of RPY in both rad/deg and in Featherstone/usual convention, etc). Required formc_rtc-magnumCMAKE_INSTALL_*where we expect relative paths (see CMake incorrect absolute include/lib paths tracking issue NixOS/nixpkgs#144170)mc_rtc::JSON_SCHEMA_PATHtomc_rtc/config.hto ensure that downstream projects use the same installed path as mc_rtc'sTo merge after: mc-rtc/mc_rtc-magnum#3
Related to: #356