Fix bug in writeBytes method for nRF51 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues writing multiple bytes from an nRF52 to an I2C slave using code ported from this lib, where my slave would randomly stop ACK-ing the writes. I found a bug in the
writeBytesmethod. The current implementation writes the data in the following order:slave address (write) - register address - slave address (write) - data.According to section 3.1 in Understanding the I2C bus from TI, the second slave address write isn't needed, and is probably what was causing my slave to stop ACK-ing.
I've fixed this in my implementation, and I've modified the method in this repo also.