This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Merge changes from ELLIOTTCABLE/master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin previously assumed that `nodenv` used $NODENV_ROOT to store the directory where *nodenv* was installed. This is not the case. This fix uses whichever directory `nodenv` is installing Node.js versions in (preferring the user-local `~/.nodenv/versions` over the system-global one.)
Critically, previous versions would fuck up the user's `$PATH` if it happened to include spaces. Unacceptable, yikes. I also refactored the script slightly, to use consistent POSIX tests, consistent casing for variable-names, etceteras.
|
Ahhah. Hello. Yes! Enjoy! 🤣 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On his fork, @ELLIOTTCABLE made these commits:
This PR merges his fork with upstream.