Continue when hotend temp above target when probing #256
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can also be made an configurable behavior with an variable, if desired |
|
please make it optionnal with a variable |
This commit prevents the probing procedure to wait for the hotend temperature to settle if its above the target temperature. This is desired, if for example, the first layer failed and the print must be restarted. We would be forced to wait until the temperature has fallen, depending on the chamber environment and hotend, this could take several minutes. Instead we ignore if its above and continue with probing, this saves time, especially when prototyping. It shouldn't be a problem anyways.
stablestud
force-pushed
the
ignore-too-hot-hotend-when-probing
branch
from
20dc71c
to
1eeab41
Compare
|
I updated the PR. |
|
@jschuh any chance to merge that PR? |
|
FWIW I came across and have been running this change for the past month and love the time savings on my Ender3 V2 setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents the probing procedure to wait for the hotend temperature to settle if its above the target temperature. This is desired, if for example, the first layer failed and the print must be restarted.
We would be forced to wait until the temperature has fallen, depending on the chamber environment and hotend,
this could take several minutes.
Instead we ignore if its above and continue with probing, this saves time, especially when prototyping. It shouldn't be a problem anyways.