Skip to content

Conversation

@Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 mentioned this pull request May 5, 2025
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the value in adding the engines field, explicitly stating that we support these versions of Node.js, but if we want this change, we should have consistency across all packages

@Phillip9587
Copy link
Contributor Author

@bjohansebas We have to options for the next release. Remove the emgines field and release v1.0.1 or publish v2

@bjohansebas
Copy link
Member

@Phillip9587 @blakeembrey This PR would go against what this ADR proposes (expressjs/discussions#289)

@blakeembrey
Copy link
Member

@bjohansebas it was noted in the comment by @wesleytodd but I’ve added a review to clarify it in the ADR since it seems to be confusing:

The only thing I think is missing is the call-out that all more restrictive engines changes can only land with a MAJOR. And that we agreed major versions should not be cut just to change node support.

@UlisesGascon
Copy link
Member

I will bring this to the next TC meeting expressjs/discussions#370 and see if we need an exception to the ADR policy to land this on 1.0.1 🤞

@Phillip9587
Copy link
Contributor Author

@UlisesGascon Has there been a decision from the TC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants