-
-
Notifications
You must be signed in to change notification settings - Fork 46
fix: remove invalid engines field #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the value in adding the engines field, explicitly stating that we support these versions of Node.js, but if we want this change, we should have consistency across all packages
|
@bjohansebas We have to options for the next release. Remove the emgines field and release v1.0.1 or publish v2 |
|
@Phillip9587 @blakeembrey This PR would go against what this ADR proposes (expressjs/discussions#289) |
|
@bjohansebas it was noted in the comment by @wesleytodd but I’ve added a review to clarify it in the ADR since it seems to be confusing:
|
|
I will bring this to the next TC meeting expressjs/discussions#370 and see if we need an exception to the ADR policy to land this on 1.0.1 🤞 |
|
@UlisesGascon Has there been a decision from the TC? |
#77 (review)
cc: @UlisesGascon @blakeembrey