Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSBuild integration for kiota generate #1670

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

bkoelman
Copy link
Member

What started as an attempt to fix incidental build failures in the IDE due to locked files (introduced in #1667) ultimately ended up in taking ideas from https://github.com/kimbell/Kiota.Testing and adding support for <KiotaReference> elements, defined in the JsonApiDotNetCore.OpenApi.Client.Kiota NuGet package.

This PR retries to save when a file is locked and tweaks the command-line parameters used in running kiota.

It also hardens the kiota-patch-generated-code.ps1 script to produce the same output when run multiple times (which shouldn't happen because IDE-based builds are disabled due to terrible responsiveness -- running multiple external processes on every keystroke surprisingly turned out to be a bad idea 😄).

QUALITY CHECKLIST

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (d9aa8d0) to head (e6a728e).
Report is 1 commits behind head on openapi.

Additional details and impacted files
@@             Coverage Diff              @@
##           openapi    #1670       +/-   ##
============================================
+ Coverage         0   90.41%   +90.41%     
============================================
  Files            0      458      +458     
  Lines            0    13984    +13984     
  Branches         0     2177     +2177     
============================================
+ Hits             0    12643    +12643     
- Misses           0      910      +910     
- Partials         0      431      +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman force-pushed the openapi-kiota-msbuild branch from 87c75a4 to e6a728e Compare January 27, 2025 00:14
@bkoelman bkoelman marked this pull request as ready for review January 27, 2025 00:40
@bkoelman bkoelman merged commit 75c1837 into openapi Jan 27, 2025
16 checks passed
@bkoelman bkoelman deleted the openapi-kiota-msbuild branch January 27, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant