-
-
Notifications
You must be signed in to change notification settings - Fork 261
remove duplicates of languages from tooling-data.yml #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicates of languages from tooling-data.yml #1512
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@benjagm I recently opened a PR(I closed) but it failed a check for changing unauthorized file. here is the proposal before making changes in those files. Feature - Adds case-insensitive unique validation for language entries Screenshots/videos: Summary
My solution:
For Tool Maintainers: # Before
languages:
- "JavaScript"
- "javascript"
- "Python"
- "PYTHON"
# After
languages:
- "JavaScript" # Use consistent casing from schema enum
- "Python" What's your feedback on this approach? |
Thanks for the PR @Vishv0407 but it seems these changes are already covered in your PR #1513 Closing this in response of it. |
What kind of change does this PR introduce?
Bug fix - remove two caseInsensetive entries of same name such as 'JavaScript' and 'Javascript'
Issue Number:
Screenshots/videos:

If relevant, did you update the documentation?
No.
Summary
Mainly I update languages which contains duplicate entries.
Does this PR introduce a breaking change?
No