Skip to content

Fix: Make entire button area clickable by applying styles directly to <Link> #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Make entire button area clickable by applying styles directly to <Link> #1579

wants to merge 2 commits into from

Conversation

techmannih
Copy link
Contributor

What kind of change does this PR introduce?
Make entire button area clickable by applying styles directly to tag

Issue Number:

@techmannih techmannih requested a review from a team as a code owner March 22, 2025 16:44
DarhkVoyd

This comment was marked as duplicate.

Sign in to view

DarhkVoyd
DarhkVoyd requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using Next.js page routes, I’d also suggest replacing <a> with Next.js <Link> where applicable.

@techmannih techmannih changed the title Fix: Make entire button area clickable by applying styles directly to <a> tag Fix: Make entire button area clickable by applying styles directly to <Link> Mar 24, 2025
@techmannih
Copy link
Contributor Author

@DarhkVoyd Thanks for pointing that out to me. There were a lot of tags used for routing. I was changing them accordingly, and now I've updated all of them to .

@techmannih
Copy link
Contributor Author

techmannih commented Apr 9, 2025 •
edited
Loading

@benjagm @DhairyaMajmudar @DarhkVoyd please review once I have updated

DarhkVoyd
DarhkVoyd approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarhkVoyd DarhkVoyd DarhkVoyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons are working only when we click on text inside
2 participants
@techmannih @DarhkVoyd