-
-
Notifications
You must be signed in to change notification settings - Fork 282
feat: Updated add "Go Back" and "Up Next" buttons for specification navig… #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Updated add "Go Back" and "Up Next" buttons for specification navig… #1743
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 29
Lines ? 548
Branches ? 158
========================================
Hits ? 548
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job ! @vtushar06 .
Just some small extra changes are to be reverted in the formatting part which I have suggested in the attached video, fixing those changes will make this PR ready to be merged.
Please refer to it.
Thank you !
2025-06-28.20-46-38.mp4
hey @Utkarsh-123github sir, I reverted changes which you pointed out, Thanks for detail guidance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @vtushar06 !
LGTM 🚀
Thanks a lot @Utkarsh-123github, Please can you suggest me others challenging issues where i can spend good amount of time in solving that. |
You're most welcome! @vtushar06 I'd suggest exploring the open issues in the repo , there are quite a few that might match your interest and skills. If you find any that you feel are challenging and you'd enjoy working on, feel free to drop a comment on the issue or let me know directly. If it's unassigned and fits well, we can definitely get it assigned to you! 🚀 |
Thank you so much @Utkarsh-123github for this humble response, |
Hi @Utkarsh-123github, just checking in to see if there are any updates or further inputs needed from my side for this PR. Thanks! |
Hey @vtushar06 , the PR doesn't needs any further changes based upon my review. I have added this PR to second review, and after that it'll get merged. |
Thank you so much @Utkarsh-123github, I appreciate your guidance and review throughout the process. Looking forward to the merge 🚀. Happy to contribute! |
Hi @Utkarsh-123github, Thanks, |
Hi @vtushar06 , Thank you so much for your enthusiasm and willingness to contribute—it’s always wonderful to see new contributors getting involved! 🙌 Just a gentle reminder: please try to avoid tagging unnecessarily or repeatedly , as it can clutter the discussion and make it harder to manage notifications. It is considered a bad practice/ approach. For instance, in this case, the issues you mentioned don’t seem directly related to the PR, which can create a bit of confusion. Rest assured, we do receive notifications and I’m actively monitoring the repository—so no worries on that front. I truly appreciate your patience as we go through the process. It’s completely okay—these things happen, especially when you’re just getting started. Just be sure to carefully review the issue context before commenting so we can keep conversations as clear and focused as possible. Thank you! |
Thank you for the kind reminder and guidance! I’ll make sure to be more mindful going forward. |
… versions (#1618)
What kind of change does this PR introduce?
Bugfix — improves UI/UX through enhanced navigation between Specification version pages.
Issue Number:
• Closes #1618
Screenshots/videos:
https://github.com/user-attachments/assets/7815d73e-23ed-4cb0-9b75-693a8bb183b1
If relevant, did you update the documentation?
Not applicable — changes are limited to component-level enhancements.
Summary
This pull request addresses the missing "Go Back" and "Up Next" navigation buttons across the Specification version pages, as discussed in issue #1618.
As part of this contribution:
• I implemented a reusable navigation component for consistency.
• Integrated the component into five Specification version pages to ensure seamless traversal across document versions.
• Validated the functionality across all affected routes for correct previous/next link logic.
• Ensured the code adheres to existing linting and styling standards.
These enhancements improve overall documentation navigation flow and accessibility for users referring to different spec versions.
Does this PR introduce a breaking change?
No — the implementation is fully backward compatible and isolated to specific pages.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
ScreenRecording.mp4