map :base attribute to '/data' source pointer if not used as an attribute#106
Open
gmkohler wants to merge 1 commit intojsonapi-rb:masterfrom
Open
map :base attribute to '/data' source pointer if not used as an attribute#106gmkohler wants to merge 1 commit intojsonapi-rb:masterfrom
:base attribute to '/data' source pointer if not used as an attribute#106gmkohler wants to merge 1 commit intojsonapi-rb:masterfrom
Conversation
:base attribute to '/data' if not used as an attribute:base attribute to '/data' source pointer if not used as an attribute
|
Might make sense to make this customizable too. I use form objects and attach exceptions to an The only thing I think might be wrong here is that nested association errors shouldn't be on base but rather on a relationship instead. However, that's not in v1 of the spec so not sure |
Author
|
@JoeWoodward can you write an example of what you mean by:
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification for
"/data"in a JSONAPI error object'ssourceattribute and the suggested usage of:baseinActiveModel::Errorseem aligned.Wrote this such that any actual
:baseattribute would override this, but not sure what sort of tests need to be added or whether it's worth adding at all.