Skip to content

Multi fetch needs the array of keys splatted. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

rovermicrover
Copy link
Contributor

In reference to this other PR #28

@beauby
Copy link
Member

beauby commented Nov 17, 2017

Thanks for the PR 👍. You'll probably need to add a splat there as well for the tests to pass.

LGTM otherwise.

@rovermicrover
Copy link
Contributor Author

Well aren't I stupid/lazy. I fixed that on the last PR and completely forgot about it my bad.

@beauby
Copy link
Member

beauby commented Nov 17, 2017

Perfect, thanks! Merging

@beauby beauby merged commit f154799 into jsonapi-rb:master Nov 17, 2017
@samnang
Copy link

samnang commented Dec 21, 2017

@beauby any chance to get a new release that contains this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants