feat: gitlab signin #1150
feat: gitlab signin #1150
Conversation
|
in |
|
@AugustinMauroy i tried, however gitlab requires an auth token to get the username so we can resolve the link, whereas github doesnt. i added the logic there, but its commented out until we figure out a solution |
api/src/docs/bulb.svg
Outdated
There was a problem hiding this comment.
where this file is used ?
There was a problem hiding this comment.
oh seems deno fmt changes formatting of a bunch of svgs. this is used explicitly in the docs gen for alerts
|
This sign in page needs an overhaul |
frontend/islands/SignInMenu.tsx
Outdated
| Sign In with GitHub | ||
| </a> | ||
| <a | ||
| href="/login/gitlab" |
There was a problem hiding this comment.
why not use tb icon like on setting page ? because now the gitlab icon on yellow bg is awful
There was a problem hiding this comment.
because from all other services that provide oauth2 logins, i see the actual logos being used, for easier brand recognition.
ie imagine adding a microsoft oath2 login. the logo in black is unrecognizable
There was a problem hiding this comment.
maybe change the background color because on this image it didn't look good
Closes #893