Make pattern encoder default #266#268
Open
agentgt wants to merge 2 commits intojstachio:mainfrom
Open
Conversation
agentgt
force-pushed
the
pattern_console_default
branch
from
1d39d82 to
4c45e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern encoder was never set as the default encoder but the jansi encoder was making configuration confusing.
The jansi encoder is pretty worthless as you cannot configure it and I mainly added it just to give rainbow gum some initial color.
The jansi encoder will be removed in the long run (jansi will stay for ansi safe output though).
There is a default encoder called TTLL always shipped with core rainbow gum that now can be accessed through URI schema.
I made it easier to register a TTLL encoder which is used if no other encoders are found / not specified. This should be separated out as different work but oh well it got put in this change.
I also found some missing Spring Boot colors while looking at the ANSI stuff in pattern module. Again probably should be separate issue.