Skip to content

Conversation

Namchee
Copy link

@Namchee Namchee commented Apr 18, 2025

Overview

This pull request replaces emoji-regex with emoji-regex-xs package that has 97% smaller size while maintaining its API and features.

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedemoji-regex-xs@​1.0.01001008176100

View full report

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good at a glance, but using it is blocked on slevithan/emoji-regex-xs#4

@Namchee
Copy link
Author

Namchee commented Apr 18, 2025

After reading through emoji-regex-xs again, I don't think it can replace emoji-regex in this repository as it requires Node 10+ while this repository asks for Node as old as 4. My bad.

@Namchee Namchee closed this Apr 18, 2025
@slevithan
Copy link

@ljharb Can you confirm that you do not want to use it if it requires (7 years old) Node.js 10?

@ljharb
Copy link
Member

ljharb commented Apr 19, 2025

Unfortunately yes, currently this package requires node 4 support.

@slevithan
Copy link

No worries. Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants