Skip to content

Feature/jump to screen#9

Open
Tazovsky wants to merge 7 commits intojuba:masterfrom
Tazovsky:feature/jump-to-screen
Open

Feature/jump to screen#9
Tazovsky wants to merge 7 commits intojuba:masterfrom
Tazovsky:feature/jump-to-screen

Conversation

@Tazovsky
Copy link
Copy Markdown

@Tazovsky Tazovsky commented Apr 2, 2020

PR introduces:

  • jump to screen buttons (named jumpBtn):
    image
  • buttons prevBtn, nextBtn, firstBtn, lastBtn which are wrappers around shiny::actionButton - thanks to that click actions can be easily observed in server
  • run example app from inst/examples/06_jump_controls to see introduced changes
  • when reviewing diffs please turn on following, because something went wrong with line ending conversion in RStudio:
    image

@Tazovsky Tazovsky force-pushed the feature/jump-to-screen branch from 7977627 to c45459f Compare April 2, 2020 21:54
@juba
Copy link
Copy Markdown
Owner

juba commented Apr 13, 2020

Hi, thanks for your PR and sorry for not answering it sooner.

Unfortunately I have some work to do on shinyglide, in relation with #8, and I think this may interfere with your PR, so I prefer not to merge it for now. But I'll take a look at it as soon as I find time to work on the package.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants