Add git_cli option for SSH configuration control #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to julia-buildpkg, this adds a git_cli input option that directly sets JULIA_PKG_USE_CLI_GIT for Julia 1.7+. This is particularly useful when tests need to clone private dependencies or work with complex SSH setups. - Added git_cli input parameter to action.yml - Directly set JULIA_PKG_USE_CLI_GIT environment variable in action.yml - Added version check warning in test_harness.jl for Julia < 1.7 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
IanButterworth
left a comment
IanButterworth
left a comment
There was a problem hiding this comment.
git_cli is too general. This is specific to pkg operations, so makes sense to make it more similar to the env var name, I think
| test_args: | ||
| description: 'Arguments string that is passed on to test.' | ||
| default: '' | ||
| git_cli: |
Member
There was a problem hiding this comment.
Suggested change
| git_cli: | |
| pkg_use_git_cli: |
| COMPILED_MODULES: ${{ inputs.compiled_modules }} | ||
| ALLOW_RERESOLVE: ${{ inputs.allow_reresolve }} | ||
| DEPWARN: ${{ inputs.depwarn }} | ||
| JULIA_PKG_USE_CLI_GIT: ${{ inputs.git_cli }} |
Member
There was a problem hiding this comment.
Suggested change
| JULIA_PKG_USE_CLI_GIT: ${{ inputs.git_cli }} | |
| JULIA_PKG_USE_CLI_GIT: ${{ inputs.pkg_use_git_cli }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to julia-buildpkg, this adds a git_cli input option that directly sets JULIA_PKG_USE_CLI_GIT for Julia 1.7+. This is particularly useful when tests need to clone private dependencies or work with complex SSH setups.
🤖 Generated with Claude Code