Skip to content

Fix for #624 to auto-calc tween values for css type values using Window.getComputedStyle().#669

Closed
tleish wants to merge 1 commit into
juliangarnier:masterfrom
tleish:calc_tween_for_css_values
Closed

Fix for #624 to auto-calc tween values for css type values using Window.getComputedStyle().#669
tleish wants to merge 1 commit into
juliangarnier:masterfrom
tleish:calc_tween_for_css_values

Conversation

@tleish
Copy link
Copy Markdown

@tleish tleish commented Mar 23, 2020

No description provided.

@tleish tleish mentioned this pull request May 8, 2020
@TomS-
Copy link
Copy Markdown

TomS- commented Oct 4, 2021

Great PR, would like to see this in v3.3.0 - things like accordions would massively benefit from this. I didn't know you could get the height of "auto" from getComputedStyle. Learn something new everyday.

@juliangarnier
Copy link
Copy Markdown
Owner

juliangarnier commented Apr 24, 2025

Sorry for the wait. Looks good, but probably needs lots of tests as I'm afraid it won't work in some cases and probably breaks others.
This is something I plan to add to v4, I'm open to a new PR on v4 if you like :)
I'm closing since v4 has been completely rewritten and this PR is not compatible.
Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants