Skip to content

1.x php 8 compatibility#22

Open
mbolli wants to merge 8 commits intojuliangut:1.xfrom
mbolli:1.x-php8
Open

1.x php 8 compatibility#22
mbolli wants to merge 8 commits intojuliangut:1.xfrom
mbolli:1.x-php8

Conversation

@mbolli
Copy link
Copy Markdown

@mbolli mbolli commented Aug 5, 2021

This is an ongoing pull request for issue #21.

  • I had to use dev-master of the juliangut/mapping repo
  • To fix the tests, I had to add a dummy AttributeDriver (would be nice to make it work as well)
  • I had to disable phpstan in the qa action, as it wanted to enforce typed properties but PHP 7.0 doesn't support these yet (solution could be to use different phpstan rules or to raise the minimum PHP 7 version)

@mbolli
Copy link
Copy Markdown
Author

mbolli commented Aug 9, 2021

It already appears to be working like this with my PHP 8.0.9.

@juliangut

  • Do you already have an AttributeDriver for the 2.x branch which you can backport?
  • Can you make a release of juliangut/mapping@b721c24 ?

@mbolli
Copy link
Copy Markdown
Author

mbolli commented Aug 26, 2021

Hey @juliangut sorry for the bump but could I get a quick feedback?

@mbolli
Copy link
Copy Markdown
Author

mbolli commented Oct 23, 2021

@juliangut
I guess you have enough to do as it is, I just want to recall this to your mind (see my questions in #22 (comment)). This would fix issue #21.

@mbolli mbolli mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant