-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a recommendation to manually set the DJANGO_SQIDS_ALPHABET setting #5
base: main
Are you sure you want to change the base?
Conversation
Sorry for not getting back sooner, I've been thinking about this notice a bit. Personally, I want to avoid any references to potential "security" issues as this is not a security library and must not be used as such. Mentioning that it's recommended to change the alphabet (I don't think it is, I haven't seen this mentioned anywhere around the Sqids project?) might make people think it's for better security or similar. Because of this I'm closing this for now. |
@julianwachholz - No worries. I know |
Thanks for the link. This Python package does provide a small |
@julianwachholz Sure! I saw the I guess we can mention both like this: WDYT? |
Sorry, I do not wish to link to a third party site for this. I am interested in adding the function as a script to be invoked (manage.py or python -m) |
@julianwachholz Okay - let's just keep it as: |
@julianwachholz - Do you have the option to re-open the pull request? If not, I can create another one. |
@julianwachholz - I am going to add a script to generate a random string that can be used as
It is probably a one time use thing per-project anyway(unless the user is manually providing a different alphabet for each field) WDYT? |
Agreed the |
@julianwachholz - have added a small script for random alphabet generation. |
By customizing the
DJANGO_SQIDS_ALPHABET
string, we can prevent the issue of generating the same IDs as those generated by other projects using the default alphabet.