Skip to content

feat: add portfolio holdings view and filtering#2810

Draft
mmioana wants to merge 8 commits intofeature/jum-801-portfolio-page-create-generic-expandable-assets-cardfrom
feature/jum-802-portfolio-page-refactor-tokens-and-defi-protocols-on-single
Draft

feat: add portfolio holdings view and filtering#2810
mmioana wants to merge 8 commits intofeature/jum-801-portfolio-page-create-generic-expandable-assets-cardfrom
feature/jum-802-portfolio-page-refactor-tokens-and-defi-protocols-on-single

Conversation

@mmioana
Copy link
Copy Markdown
Contributor

@mmioana mmioana commented Apr 14, 2026

Which Jira task belongs to this PR?

Closes https://linear.app/lifi-linear/issue/JUM-802/portfolio-page-refactor-tokens-and-defi-protocols-on-single-tabbed

  • Need to check if we want to show the disabled tabs for Performance/Transactions

Why did I implement it this way?

Checklist before requesting a review

  • I have performed a self-review of my code
  • This pull request is as small as possible and only tackles one problem
  • I have added tests that cover the functionality / test the bug
  • If this changed the API, I have updated the documentation
  • I have provided QA instructions for the feature / fix implemented in this PR (if applicable)
  • I have provided instructions for any environment / deployment changes that this PR needs when merged

@mmioana mmioana self-assigned this Apr 14, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
jumper-exchange Ready Ready Preview, Comment Apr 14, 2026 8:03am
jumper-exchange-storybook Ready Ready Preview, Comment Apr 14, 2026 8:03am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9e0361ef-7f23-443c-9343-e892b9b074e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/jum-802-portfolio-page-refactor-tokens-and-defi-protocols-on-single

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

✅ All snapshot tests passed

@mmioana mmioana changed the title Feature/jum 802 portfolio page refactor tokens and defi protocols on single feat: add portfolio holdings view and filtering Apr 14, 2026
@github-actions
Copy link
Copy Markdown

Playwright test results

failed  3 failed
passed  51 passed
flaky  1 flaky
skipped  1 skipped

Details

stats  56 tests across 11 suites
duration  13 minutes, 50 seconds
commit  29288e3

Failed tests

chromium › earnPage.spec.ts › Analytics filters on Earn page › Should be able to verify analytics buttons are visible (Qase ID: 47)
chromium › portfolioPage.spec.ts › Portfolio page › Verify elements and filters on portfolio page › verify portfolio page elements and filters on Tokens and DeFi Protocols tabs (Qase ID: 53)
chromium › portfolioPage.spec.ts › Portfolio page › Verify elements and filters on portfolio page › verify that deposit and withdraw buttons are visible on DeFI positions tab

Flaky tests

chromium › mainMenu.spec.ts › Main Menu flows › Should be able to navigate to the Terms Of Business page (Qase ID: 54)

Skipped tests

chromium › themeManipulation.spec.ts › Switch between dark and light theme and check the background color › Partner theme should appear in theme menu and apply background color (Qase ID: 49)

📋 View Detailed Qase Report

@mmioana mmioana force-pushed the feature/jum-801-portfolio-page-create-generic-expandable-assets-card branch from be07f91 to f518f15 Compare April 28, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant